Fixed bugs to enable arithmetic module swap#8432
Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom Sep 26, 2025
Merged
Fixed bugs to enable arithmetic module swap#8432maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Collaborator
openroad-ci
commented
Sep 25, 2025
openroad-ci
commented
- cleared STA driver pin cache during para update because this may become stale after module swap
- added hooks for incremental para update for module swap
1) cleared STA driver pin cache during para update because this may become stale after module swap 2) added hooks for incremental para update for module swap Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
@eder-matheus, @jhkim-pii, @povik, please note the bug fix in EST updateParasitics(). When netlist change happens, especially with hierarchical module swap, driver pin cache from STA can become stale, leading to fatal during updateParasitics. This bug fix improved QoR for one rsz regression test: repair_setup9_hier. |
povik
reviewed
Sep 25, 2025
Contributor
|
I confirm that this PR fixes the issue #8441. |
maliberty
approved these changes
Sep 26, 2025
maliberty
merged commit b4a094a
into
The-OpenROAD-Project:master
10 of 12 checks passed
Contributor
|
Issue #8443 captures the task of moving the driver pin cache update out of EST module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.