EST: Remove dead code#8703
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Oct 22, 2025
Merged
Conversation
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 22, 2025
maliberty
merged commit da61325
into
The-OpenROAD-Project:master
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
est::SteinerTree::distancemethod had a wrong computing of distance between 2 non-neighbor points. On further inspection this method was only used byest::EstimateParasitics::totalLoadandest::EstimateParasitics::subtreeLoad, both were never used.This PR removes the wrong code form
est::SteinerTreeand the dead code from est::EstimateParasitics