ram/rsz: disable tests that are non-deterministic in bazel#8709
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
e2b99b4 to
70f6f79
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@hongted FYI |
|
Note: report_buffers tests should be fixed by #8699 |
|
Unless addressed by another PR. //src/rsz/test:repair_tie11_hier-tcl_test are also non-determnistic. |
|
@rovinski @braydenlouie the ram unit test gives different results in bazel than cmake so something is non-deterministic in the code. Please take a look. |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
ram test difference is due to Bazel using libc++ by default vs libstdc++. Can be confirmed by testing with system libstdc++ via edit to MODULE.bazel per #8610 |
|
@maliberty so anything actionable for us or no? |
|
@rovinski yes, figure out why the test gives different results with bazel vs cmake and re-enable it with a fix. |
|
@hongted said above that it's due to linking different libc versions. The new RAM test runs several other tools, including DRT, GRT, and PDN, which are all on the list in #8610. It probably follows that those are the source of the problem. If you want we could just add a separate test which is only the ram tool? I can't see how that one would vary because there is no sorting or anything I can see that would cause different behavior. |
No description provided.