Skip to content

ram/rsz: disable tests that are non-deterministic in bazel#8709

Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:disable-bzl-non-deterministic-tests
Oct 22, 2025
Merged

ram/rsz: disable tests that are non-deterministic in bazel#8709
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:disable-bzl-non-deterministic-tests

Conversation

@openroad-ci
Copy link
Collaborator

No description provided.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@openroad-ci openroad-ci force-pushed the disable-bzl-non-deterministic-tests branch from e2b99b4 to 70f6f79 Compare October 22, 2025 21:44
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

@hongted FYI

@maliberty maliberty enabled auto-merge October 22, 2025 21:54
@hongted
Copy link
Contributor

hongted commented Oct 22, 2025

Note: report_buffers tests should be fixed by #8699

@hongted
Copy link
Contributor

hongted commented Oct 22, 2025

Unless addressed by another PR.

//src/rsz/test:repair_tie11_hier-tcl_test
//src/rsz/test:repair_tie12_hier-tcl_test
//src/rsz/test:resize_slack2-tcl_test

are also non-determnistic.

@maliberty
Copy link
Member

@rovinski @braydenlouie the ram unit test gives different results in bazel than cmake so something is non-deterministic in the code. Please take a look.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hongted
Copy link
Contributor

hongted commented Oct 22, 2025

ram test difference is due to Bazel using libc++ by default vs libstdc++.

Can be confirmed by testing with system libstdc++ via edit to MODULE.bazel per #8610

@maliberty maliberty merged commit 9d013fc into The-OpenROAD-Project:master Oct 22, 2025
13 checks passed
@maliberty maliberty deleted the disable-bzl-non-deterministic-tests branch October 22, 2025 23:05
@rovinski
Copy link
Collaborator

@maliberty so anything actionable for us or no?

@maliberty
Copy link
Member

@rovinski yes, figure out why the test gives different results with bazel vs cmake and re-enable it with a fix.

@rovinski
Copy link
Collaborator

@hongted said above that it's due to linking different libc versions.

The new RAM test runs several other tools, including DRT, GRT, and PDN, which are all on the list in #8610. It probably follows that those are the source of the problem.

If you want we could just add a separate test which is only the ram tool? I can't see how that one would vary because there is no sorting or anything I can see that would cause different behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments