gpl: Factor out graphics use in gpl

[hongted]

No description provided.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[maliberty]

Please don't force push after code review has started as it breaks the "changes since last review" feature in GH (the last reviewed commit is elimiated).

[maliberty]

Why are we making copies of the graphics object rather than share one?

[hongted]

That's to match the existing behavior where each object has its own Graphics object. The graphics object does have internal state, but I've not done the analysis to see if every object can share one.

OpenROAD/src/gpl/src/nesterovPlace.cpp

Lines 56 to 63 in 4175450

	graphics_ = std::make_unique<Graphics>(log_,
	this,
	pbc,
	nbc,
	pbVec,
	nbVec,
	npVars_.debug_draw_bins,
	npVars.debug_inst);

OpenROAD/src/gpl/src/mbff.cpp

Line 2498 in 4175450

graphics_ = std::make_unique<Graphics>(log_);

OpenROAD/src/gpl/src/initialPlace.cpp

Line 52 in 4175450

graphics = std::make_unique<Graphics>(log_, pbc_, pbVec_);

OpenROAD/src/gpl/src/graphics.h

Lines 135 to 143 in 4175450

	static constexpr size_t kInvalidIndex = std::numeric_limits<size_t>::max();
	size_t selected_ = kInvalidIndex;
	bool draw_bins_ = false;
	utl::Logger* logger_ = nullptr;
	HeatMapType heatmap_type_ = Density;
	LineSegs mbff_edges_;
	std::vector<odb::dbInst*> mbff_cluster_;
	Mode mode_;
	gui::Chart* chart_{nullptr};

[hongted]

Please don't force push after code review has started as it breaks the "changes since last review" feature in GH (the last reviewed commit is elimiated).

Understood, I'll do so in the future.

Also, I don't know if it's the same as "changes since last review", you can see the updates after a force-push via the "compare" link in this discussion. It does include changes due to the rebase and not just the commit though.

[gudeh]

I realized a small oversight on this change. We now only plot the GUI charts if in debug mode.