pdn: Give pins stable order #8904
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,6 +616,11 @@ void PadDirectConnectionStraps::initialize(ConnectionType type) | |
| break; | ||
| } | ||
|
|
||
| std::sort(pins_.begin(), pins_.end(), [](odb::dbBox* l, odb::dbBox* r) { | ||
| return std::make_tuple(l->xMin(), l->xMax(), l->yMin(), l->yMax()) | ||
|
Contributor
There was a problem hiding this comment. warning: no header providing "std::make_tuple" is directly included [misc-include-cleaner] src/pdn/src/straps.cpp:14: - #include <utility>
+ #include <tuple>
+ #include <utility> |
||
| < std::make_tuple(r->xMin(), r->xMax(), r->yMin(), r->yMax()); | ||
| }); | ||
|
Contributor
There was a problem hiding this comment. While sorting here does close the discrepancy between my local runs and the CI, @gadfort points out
Collaborator
There was a problem hiding this comment. My concern here is that this is only masking the issue, as far as I can tell the order of these boxes matches the order they are in the database. Have you checked that the ordering of these boxes in the database differs?
Collaborator
There was a problem hiding this comment. Also, why not just use the compare provided by the database for sorting
Contributor
There was a problem hiding this comment.
I take that as sorting
Collaborator
There was a problem hiding this comment. I took a look, the order of
Collaborator
There was a problem hiding this comment. I actually think a much more likely culprit might be the rtree storing the shapes. This would cause the order in which we write the shapes to the database to differ because the order in the tree is different. |
||
|
|
||
| debugPrint(getLogger(), | ||
| utl::PDN, | ||
| "Pad", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use a ranges version of this algorithm [modernize-use-ranges]