Skip to content

grt: Add use of DRT access points to CUGR#8996

Merged
eder-matheus merged 11 commits intoThe-OpenROAD-Project:masterfrom
rafaelmoresco:cugrAP
Dec 23, 2025
Merged

grt: Add use of DRT access points to CUGR#8996
eder-matheus merged 11 commits intoThe-OpenROAD-Project:masterfrom
rafaelmoresco:cugrAP

Conversation

@rafaelmoresco
Copy link
Contributor

@rafaelmoresco rafaelmoresco commented Dec 9, 2025

CUGR uses the preferred access points generated by DRT when abailable in ODB. When not avaliable, CUGR does the usual calculations to find its own access points.

closes #8826
closes #8824

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
@eder-matheus
Copy link
Member

@rafaelmoresco It seems that some clang-tidy requestes were not addressed. Please take a look at it.

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
@rafaelmoresco rafaelmoresco marked this pull request as ready for review December 18, 2025 17:02
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

return unit_length_short_costs_[layer_index];
}
void convertODBtoCUGR(AccessPointSet& selected_access_points,
odb::dbAccessPoint* ap,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "odb::dbAccessPoint" is directly included [misc-include-cleaner]

src/grt/src/cugr/src/GridGraph.h:15:

- #include "robin_hood.h"
+ #include "odb/db.h"
+ #include "robin_hood.h"

Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus merged commit 3df4ce0 into The-OpenROAD-Project:master Dec 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRT: CUGR should use the access points generated by DRT when available GRT: extra guides covering IO pin when using CUGR

2 participants