gui: allow more than one animated gif to be generated at a time#9008
Merged
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom Dec 11, 2025
Merged
Conversation
openroad-ci
force-pushed
the
gui-multi-gif
branch
from
9eb91b4 to
ba689dd
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
openroad-ci
force-pushed
the
gui-multi-gif
branch
from
ba689dd to
e42920f
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
requested changes
Dec 10, 2025
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
approved these changes
Dec 10, 2025
Collaborator
gadfort
left a comment
gadfort
left a comment
There was a problem hiding this comment.
LGTM, just need to update the docs too:
https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/src/gui#generate-animated-images
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
merged commit 0526260
into
The-OpenROAD-Project:master
11 of 13 checks passed
Member
|
@gudeh you can go ahead and use this to add more gifs as you need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.