rsz: sort the dont-use report for stability and enable test in bzl #9168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliberty
approved these changes
Dec 30, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a natural sort helper function to provide stable output for the dont-use report and enables several tests in Bazel. The changes look good, especially the move to stabilize test outputs. I have one suggestion to improve the robustness of the new natural_compare function by using a more modern and safer C++ function for string-to-number conversion.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
openroad-ci
force-pushed
the
rsz-sort-dont-use-reporting
branch
from
d725472 to
9906991
Compare
Enable these three tests in bazel: - "liberty_dont_use" - "report_dont_use" - "report_dont_use_corners" A sort helper is introduced in utl. Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
rsz-sort-dont-use-reporting
branch
from
9906991 to
e70a6e0
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable these three tests in bazel:
A sort helper is introduced in utl.