misc: mock array instability #9170
Draft
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rafaelmoresco <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses test instability in the mock-array power test by introducing two key improvements. First, it sorts the list of pins to ensure a deterministic processing order, which is a solid approach to eliminate test flakiness. Second, it replaces an exact floating-point comparison with a tolerance-based check, making the power value verification more robust against minor precision variations. Both changes are well-implemented and should effectively improve the stability of the test.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: rafaelmoresco <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instability on mock array. Issue is not reproducible in the gcp. Initial analysis with ASAN was not helpful, tests fail on floorplan stage due to memory leak.
Closes #9062