GRT: add options for repair antennas #9181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tennas Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tennas Signed-off-by: luis201420 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new options for the repair_antennas command, allowing users to specify repair strategies using jumpers only or diodes only, and to allow congestion during rerouting. The changes are consistently applied across the C++, SWIG, and Tcl files. The logic correctly handles the new flags, including a check for mutually exclusive options. My review identified a minor stylistic issue regarding indentation in the Tcl script.
eder-matheus
requested changes
Dec 31, 2025
Member
eder-matheus
left a comment
eder-matheus
left a comment
There was a problem hiding this comment.
Please address clang-format and also add some unit tests for the new flags.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…tennas Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tennas Signed-off-by: luis201420 <[email protected]>
eder-matheus
approved these changes
Jan 5, 2026
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9042
Add the next flags for
repair_antennascommand:allow_congestion: Allow congestion when rerouting repaired nets.jumper_only: Use only jumpers to repair nets.diode_only: Use only diodes to repair nets.