-
Notifications
You must be signed in to change notification settings - Fork 759
gpl: min congestion and inflation defaults modifications #9192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gudeh
wants to merge
24
commits into
The-OpenROAD-Project:master
Choose a base branch
from
gudeh:gpl-min-congestion-inflation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52,798
−53,408
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
df7963c
gpl: set minInflationRatio as TCL parameter,
gudeh cf81a62
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 9c55230
gpl: 0.85 default min congestion inflation
gudeh e2b67ea
gpl: fix typo
gudeh 500ba37
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 838a862
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 9e149fe
gpl: remove comments, modify defualt value
gudeh 0ecacc1
gpl: move cell inflation report to function and call it after TD
gudeh 3a1bd76
gpl: call print properly
gudeh 295d7b4
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 1108e8f
gpl: rename minInflationRatio to minCongestionForInflation
gudeh 80069fe
gpl: reduce min congestion threshold for inflating from 1.01 to 0.95,
gudeh ff9d9b2
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 44ec6aa
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 1188f89
gpl: lower inflation
gudeh 32052f6
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 8108c2f
gpl: use best pobserved default inflation values with slang
gudeh b0e2406
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh 5f06f8f
gpl: remove unecessary prints and transform new ones into debugCheck
gudeh 12471c3
gpl: clang-tidy
gudeh 24a0cf9
gpl: address gemini reviews,
gudeh 9da1e25
test: update after gpl inflation modifications
gudeh 8375fa4
Merge remote-tracking branch 'private/master' into gpl-min-congestion…
gudeh a91c913
test: update after gpl inflation modifcations
gudeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The median calculation
cell_inflation_ratios[cell_inflation_ratios.size() / 2]is only correct for vectors with an odd number of elements. For an even number of elements, the median should be the average of the two middle elements. This issue also exists in the duplicated statistics calculation logic incalculateRudyTiles. This should be fixed in the suggested helper function.Additionally, for calculating
sumandvariance, you could usestd::accumulatefrom the<numeric>header for more concise code.