grt: fix GRT-0103 Extra Run for hard design #9195
Conversation
fixes The-OpenROAD-Project#9190 Signed-off-by: Øyvind Harboe <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a log message for clarity, changing "benchmark" to "design". The change is correct and the associated test files have been updated accordingly. I have one suggestion to improve code readability by replacing magic numbers with named constants in the vicinity of the change.
|
clang-tidy review says "All clean, LGTM! 👍" |
| if (i == 20 && past_cong > 200) { | ||
| if (verbose_) { | ||
| logger_->info(GRT, 103, "Extra Run for hard benchmark."); | ||
| logger_->info(GRT, 103, "Extra Run for hard design."); |
There was a problem hiding this comment.
@oharboe with the iteration count, I wonder if removing this message wouldn't be better (it's not adding anything as far as I can tell)?
There was a problem hiding this comment.
Makes sense.
I don't recalls seeing the iteration count previously, recent?
|
I did add iteration count in the past month or so |
😌 |
3 participants
fixes #9190