Enable various bzl tests #9253
Enable various bzl tests #9253
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables several previously manual or disabled Bazel tests across dbSta, pdn, rsz, and utl. The changes are mostly correct and achieve this by refactoring the test lists in the BUILD files. The changes look good and align with the PR's goal. I found one minor issue in src/rsz/test/BUILD where two tests seem to be unintentionally left out from being enabled.
I am having trouble creating individual review comments. Click here to see my feedback.
src/rsz/test/BUILD (234-246)
The tests repair_tie11_hier and repair_tie12_hier are being removed from MANUAL_FOR_BAZEL_TESTS, but they are not present in the TESTS list. This means they will not be run. If the intention of this PR is to enable these tests, they should be added to the TESTS list (defined from line 11). Other tests from this removed list are already part of TESTS.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
openroad-ci
force-pushed
the
bzl-tests
branch
from
3f3b265 to
ec15a7f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
/gemini review |
2 participants
No description provided.