narrow the data dependencies in bzl tests

[openroad-ci]

No description provided.

[gemini-code-assist]

Code Review

This pull request is a great step towards improving the build system by narrowing data dependencies for tests. This will improve build times and correctness. I've identified several opportunities to further refactor the new dependency lists in the BUILD files to reduce duplication and improve maintainability by using variables for common sets of dependencies. My suggestions are in src/ant/test/BUILD, src/cts/test/BUILD, src/dbSta/test/BUILD, src/dft/test/BUILD, src/dpl/test/BUILD, and src/mpl/test/BUILD.

[gemini-code-assist]

To improve maintainability and reduce duplication, you can define variables for common dependency lists and reuse them.

For example, you can define these variables before the list comprehension at line 32:

CHECK_API_DRT_DEPS = [
    "merged_spacing.lef",
    "sw130_random.def",
]
NO_CHECK_GRT1_DEPS = [
    "gcd_sky130.def",
    "sky130hs/sky130hs_tt.lib",
    "sky130hs/sky130hs_std_cell.lef",
]

Then, you can use them in the dictionary like this:

Suggested change

	"check_api1": [
	"merged_spacing.lef",
	"sw130_random.def",
	],
	"check_drt1": [
	"merged_spacing.lef",
	"sw130_random.def",
	],
	"check_grt1": [
	"gcd_sky130.def",
	"sky130hs/sky130hs_tt.lib",
	"sky130hs/sky130hs_std_cell.lef",
	"sky130hs/sky130hs.tlef",
	],
	"no-check_grt1": [
	"gcd_sky130.def",
	"sky130hs/sky130hs_tt.lib",
	"sky130hs/sky130hs_std_cell.lef",
	],
	"check_api1": CHECK_API_DRT_DEPS,
	"check_drt1": CHECK_API_DRT_DEPS,
	"check_grt1": NO_CHECK_GRT1_DEPS + ["sky130hs/sky130hs.tlef"],
	"no-check_grt1": NO_CHECK_GRT1_DEPS,

[gemini-code-assist]

To improve maintainability and reduce duplication, you could define variables for the dependency lists, especially for countdown_asap7 which has many files. This would make the BUILD file cleaner and easier to manage.

For example:

AES_NANGATE45_DEPS = [
    "Nangate45/Nangate45.lef",
    "Nangate45/Nangate45_stdcell.lef",
    "Nangate45/Nangate45_typ.lib",
]
COUNTDOWN_ASAP7_DEPS = [
    "asap7/asap7_tech_1x_201209.lef",
    "asap7/asap7sc7p5t_28_R_1x_220121a.lef",
    "asap7/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz",
    "asap7/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz",
    "asap7/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz",
    "asap7/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib",
    "asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz",
]
IBEX_SKY130HD_DEPS = [
    "sky130hd/sky130_fd_sc_hd__ss_n40C_1v40.lib",
    "sky130hd/sky130hd.tlef",
    "sky130hd/sky130hd_std_cell.lef",
]

Then use these variables in the dictionary.

[gemini-code-assist]

This dictionary has a lot of duplicated dependency lists. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, you can define variables for these common lists before the list comprehension at line 86.

Here are some suggestions for variables:

ARRAY_DEPS = [
    "array_tile.lef",
    "array_tile.lib",
]
ARRAY_INS_DELAY_DEPS = [
    "array_tile_ins_delay.lef",
    "array_tile_ins_delay.lib",
]
CHECK_BUFFERS_DEF_DEP = ["check_buffers.def"]
SINKS16_DEF_DEP = ["16sinks.def"]
CTS_HELPERS_DEP = ["cts-helpers.tcl"]

Then you can use these variables to simplify the dictionary.

[gemini-code-assist]

This dictionary contains a lot of duplicated dependency lists and subset relationships. To improve readability and maintainability, consider defining variables for common dependencies before the list comprehension at line 92.

For example:

HIER1_V_DEP = ["hier1.v"]
EXAMPLE1_BASE_DEPS = ["example1.def", "example1.lef"]
STA1_DEPS = ["example1_slow.lib"] + EXAMPLE1_BASE_DEPS
BUS1_DEPS = [
    "bus1.lef",
    "bus1.lib",
]

Then you can reuse these variables in the dictionary, which will make it much cleaner.

[gemini-code-assist]

To avoid duplication, you can define a variable for the dependency shared by scan_architect_clock_mix_sky130 and scan_architect_no_mix_sky130.

Define this before the list comprehension at line 41:

SCAN_ARCHITECT_SKY130_V_DEP = ["scan_architect_sky130.v"]

Then use it in the dictionary.

            "scan_architect_clock_mix_sky130": SCAN_ARCHITECT_SKY130_V_DEP,
            "scan_architect_no_mix_sky130": SCAN_ARCHITECT_SKY130_V_DEP,

[gemini-code-assist]

This dictionary has a lot of duplicated dependency lists. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, you can define variables for these common lists before the list comprehension at line 64.

For example:

IO_CONSTRAINTS1_BASE_DEPS = [
    "testcases/io_constraints1.def",
    "testcases/io_constraints1.v",
    "testcases/macro_only.lef",
    "testcases/macro_only.lib",
]
IO_CONSTRAINTS6_BASE_DEPS = [
    "Nangate45/Nangate45_fast.lib",
    "testcases/io_constraints6.def",
    "testcases/macro_only.lef",
]
ORIENTATION_IMPROVE1_DEPS = [
    "testcases/orientation_improve1.def",
    "testcases/orientation_improve1.lef",
]
MACRO_ONLY_DEPS = [
    "testcases/macro_only.def",
    "testcases/macro_only.lef",
    "testcases/macro_only.lib",
    "testcases/macro_only.v",
]

Then you can use these variables to simplify the dictionary.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[maliberty]

The gemini comments are reasonable but I'll leave refactoring to later