Resume recovery optimizor scheduler#559
Open
Sualeh77 wants to merge 2 commits intorefactor/consolidationfrom
Open
Resume recovery optimizor scheduler#559Sualeh77 wants to merge 2 commits intorefactor/consolidationfrom
Sualeh77 wants to merge 2 commits intorefactor/consolidationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Task: Optimizer state restored correctly (momentum, variance).
When training is paused and resumed from a checkpoint, DeepSpeed's load_checkpoint restores optimizer and scheduler states automatically. However, there was no verification that this restore actually succeeded — a silent failure (empty buffers, reset LR) would cause training to diverge without any warning.
This PR adds:
verify_optimizer_scheduler_restored() in llm/src/llm/utils.py — a standalone, testable function that checks:
Unit tests in llm/tests/test_checkpoint_restore.py — 6 tests exercising the actual production function:
Key files changed
Checklist