Generation quality: Test prompts defined (diverse: factual, reasoning…#566
Open
Sualeh77 wants to merge 1 commit intorefactor/consolidationfrom
Open
Generation quality: Test prompts defined (diverse: factual, reasoning…#566Sualeh77 wants to merge 1 commit intorefactor/consolidationfrom
Sualeh77 wants to merge 1 commit intorefactor/consolidationfrom
Conversation
…, creative, code) Generation tested at checkpoints (temperature=0 for reproducibility) Generation samples logged/saved for review Repetition and degeneration checked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive generation quality monitoring to the training pipeline, addressing the four key requirements of the Generation Quality task:
factual,reasoning,creative, andcode. This allows for tracking qualitative improvements across domains.temperature=0/ greedy decoding) to ensure reproducible and consistent qualitative evaluation at key training milestones.<output_dir>/generation_samples/run_<run_id>_samples.jsonl) for easy tracking and review without depending on the observability stack. Logs also go to the P12 logger if it is active.degeneration_warning(>0.3 score) anddegeneration_critical(>0.7 score) alerts to the observability backend.Key Implementation Details for Reviewers:
model.generate()call, eliminating sequential inference latency during the training loop.generated_this_stepflag was added to the training loop to prevent redundant sequential generations when a step interval and checkpoint interval align.Related Issue: [Link to issue / Task List]
Checklist