switches to using parquet files that have been extracted for the model#297
switches to using parquet files that have been extracted for the model#297tomjemmett merged 10 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 999 999
=========================================
Hits 999 999 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Rhian Davies <thetrianglegirl@gmail.com>
|
Wasn't expecting you to respond on your day off @tomjemmett! |
|
We're not currently able to run this on Other minor changes which are suggested
Once it's fixed, I intend to compare with a run I did on Thursday afternoon to ensure similar numbers before approving |
|
Have checked why it's not running on dev data - there are duplicates in the activity_avoidance. Example below. RAP should have been mapped to RAL (successor organisation) - so the RAP rows of activity should have been removed? Can get round this by doing drop_duplicates but this flags an issue in nhp_data perhaps |
|
Ok so in summary: the notebook runs on v3.1 data. I don't think we can approve the PR until it runs on dev / v3.2 data as well. So we're awaiting the data fix. have raised an issue here: The-Strategy-Unit/nhp_data#43 |
Co-authored-by: Rhian Davies <thetrianglegirl@gmail.com>
StatsRhian
left a comment
There was a problem hiding this comment.
Sorry forgot one data_version
Co-authored-by: Rhian Davies <thetrianglegirl@gmail.com>

No description provided.