Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 999 1002 +3
=========================================
+ Hits 999 1002 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomjemmett
left a comment
There was a problem hiding this comment.
I thought we was going to add the metadata as columns to the parquet files? The metadata will be "lost" as soon as a file is downloaded as it's only a function of azure storage.
|
Both, basically. Exposing the metadata on |
|
Yes we did that already here @tomjemmett #296 |
|
Ah cool, must have forgot or missed that! Checked for issues, but if it's already done... 😝 |
Closes #299
Note that with this PR, we will be adding metadata to two different files. For example for a scenario with name
exampleinv3.2, for providerXYZ, with runtimeruntime, metadata will be added to both of these files in the results storage container:prod/v3.2/XYZ/example-runtime.json.gz- we will deprecate this in the medium to long termparams.jsonfile, saved inaggregated-model-results/v3.2/XYZ/example/runtime/params.jsonDoes this work @matt-dray ?