Skip to content

uses new parameter format for non-demographic growth#308

Merged
tomjemmett merged 1 commit intomainfrom
update_ndg
Mar 10, 2025
Merged

uses new parameter format for non-demographic growth#308
tomjemmett merged 1 commit intomainfrom
update_ndg

Conversation

@tomjemmett
Copy link
Member

@tomjemmett tomjemmett commented Mar 6, 2025

Closes #307

@tomjemmett tomjemmett added enhancement New feature or request priority: should We should implement this feature labels Mar 6, 2025
@tomjemmett tomjemmett self-assigned this Mar 6, 2025
@tomjemmett tomjemmett requested a review from yiwen-h March 6, 2025 14:50
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (022aa8b) to head (fab4cc8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          999      1003    +4     
=========================================
+ Hits           999      1003    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomjemmett
Copy link
Member Author

@matt-dray inputs dev will fail to run until we update the selection app

@yiwen-h
Copy link
Member

yiwen-h commented Mar 7, 2025

It's getting increasingly important that inputs selection app becomes an independent entity from nhp_inputs I think

@tomjemmett tomjemmett merged commit 4975072 into main Mar 10, 2025
3 checks passed
@tomjemmett tomjemmett deleted the update_ndg branch March 10, 2025 09:42
@tomjemmett
Copy link
Member Author

It's getting increasingly important that inputs selection app becomes an independent entity from nhp_inputs I think

the problem is, there is a fixed dependency between the two for development, so separating into it's own entity isn't entirely straightforward. the most obvious "solution" would be to use git submodules, but that brings a whole host of complexity in itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: should We should implement this feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model should accept new format of params for non-demographic growth

2 participants