Skip to content

Tidy notebooks folder#309

Merged
StatsRhian merged 2 commits intomainfrom
StatsRhian/issue282
Mar 11, 2025
Merged

Tidy notebooks folder#309
StatsRhian merged 2 commits intomainfrom
StatsRhian/issue282

Conversation

@StatsRhian
Copy link
Member

@StatsRhian StatsRhian commented Mar 10, 2025

Closes #282.

Related to The-Strategy-Unit/nhp_data#72

@StatsRhian StatsRhian changed the title StatsRhian/issue282 Tidy notebooks folder Mar 10, 2025
@StatsRhian StatsRhian requested a review from tomjemmett March 10, 2025 15:50
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4975072) to head (5820fbf).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1006      1006           
=========================================
  Hits          1006      1006           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@tomjemmett tomjemmett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notebooks/generate_synthetic_datasets.ipynb should remain in here for now as it's specifically tied to testing the model. the data isn't inserted into any of our databricks workspace

that said, the file is broken at present

@StatsRhian StatsRhian force-pushed the StatsRhian/issue282 branch from 5820fbf to 0d33688 Compare March 11, 2025 16:33
@StatsRhian StatsRhian requested a review from yiwen-h as a code owner March 11, 2025 16:33
@StatsRhian
Copy link
Member Author

notebooks/generate_synthetic_datasets.ipynb should remain in here for now as it's specifically tied to testing the model. the data isn't inserted into any of our databricks workspace

that said, the file is broken at present

Commit amended to not delete notebooks/generate_synthetic_datasets.ipynb. And made an issue #311

@StatsRhian StatsRhian requested a review from tomjemmett March 11, 2025 16:35
@StatsRhian StatsRhian merged commit 5c5fcf7 into main Mar 11, 2025
1 check passed
@StatsRhian StatsRhian deleted the StatsRhian/issue282 branch March 11, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review notebooks folder

3 participants