Merged
Conversation
was previously not pushing the latest container to acr correctly, as it was trying to get a container of the form *.azurecr.io:vX.X, missing out the /nhp_model part. taking the opportunity to reorganise the action to handle acr/ghcr deployment to two separate jobs to aid in debugging issues
tomjemmett
added
bug
priority: must
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1006 1006
=========================================
Hits 1006 1006 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yiwen-h
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was previously not pushing the latest container to acr correctly, as it was trying to get a container of the form *.azurecr.io:vX.X, missing out the /nhp_model part.
taking the opportunity to reorganise the action to handle acr/ghcr deployment to two separate jobs to aid in debugging issues