Skip to content

Add calibration coefficients#147

Merged
morganle-48 merged 2 commits intomainfrom
add-calibration-coefficients
Dec 19, 2025
Merged

Add calibration coefficients#147
morganle-48 merged 2 commits intomainfrom
add-calibration-coefficients

Conversation

@morganle-48
Copy link
Collaborator

No description provided.

@morganle-48 morganle-48 requested a review from yiwen-h as a code owner December 19, 2025 10:17
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.49%. Comparing base (5be456c) to head (aa6a864).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
renal_capacity_model/load_scenario.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   86.60%   86.49%   -0.12%     
==========================================
  Files           9        9              
  Lines         642      644       +2     
  Branches       73       73              
==========================================
+ Hits          556      557       +1     
- Misses         78       79       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Can I please have a copy of the new Excel file inputs with the multipliers - via email or Teams? so I can test locally

Also - I notice * self.config.multipliers["ttd"][patient.dialysis_modality] is sometimes commented out in your PR - is this intentional?

Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tested with the new file! Just checking you intentionally left those lines commented out - otherwise happy for you to merge

self.config.time_to_event_curves[
f"ttd_{patient.dialysis_modality}_initialisation"
].loc[random_number, patient.patient_type]
# * self.config.multipliers["ttd"][patient.dialysis_modality]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for now

@morganle-48
Copy link
Collaborator Author

morganle-48 commented Dec 19, 2025 via email

@morganle-48 morganle-48 merged commit c85a505 into main Dec 19, 2025
6 checks passed
@morganle-48 morganle-48 deleted the add-calibration-coefficients branch December 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants