Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 86.60% 86.49% -0.12%
==========================================
Files 9 9
Lines 642 644 +2
Branches 73 73
==========================================
+ Hits 556 557 +1
- Misses 78 79 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yiwen-h
left a comment
There was a problem hiding this comment.
Hello! Can I please have a copy of the new Excel file inputs with the multipliers - via email or Teams? so I can test locally
Also - I notice * self.config.multipliers["ttd"][patient.dialysis_modality] is sometimes commented out in your PR - is this intentional?
yiwen-h
left a comment
There was a problem hiding this comment.
Looks good to me - tested with the new file! Just checking you intentionally left those lines commented out - otherwise happy for you to merge
| self.config.time_to_event_curves[ | ||
| f"ttd_{patient.dialysis_modality}_initialisation" | ||
| ].loc[random_number, patient.patient_type] | ||
| # * self.config.multipliers["ttd"][patient.dialysis_modality] |
|
I was playing with editing the different distributions so yes they were meant to be commented (at least for now)
Dr Lucy Morgan (she/her)
Analytics Manager (Simulation)
The Strategy Unit
T: 07397981495
E: ***@***.***
[cid:0e383cd6-2343-441e-8bab-2bc357712269]
Leading research, analysis and change from within the NHS.
W: www.strategyunitwm.nhs.uk<http://www.strategyunitwm.nhs.uk/>
________________________________
From: YiWen Hon ***@***.***>
Sent: 19 December 2025 15:20
To: The-Strategy-Unit/renal-capacity-model ***@***.***>
Cc: MORGAN, Lucy (NHS MIDLANDS AND LANCASHIRE COMMISSIONING SUPPORT UNIT) ***@***.***>; Author ***@***.***>
Subject: Re: [The-Strategy-Unit/renal-capacity-model] Add calibration coefficients (PR #147)
This message originated from outside of NHS.net Connect. Please do not click links or open attachments unless you recognise the sender and know the content is safe.
@yiwen-h approved this pull request.
Looks good to me - tested with the new file! Just checking you intentionally left those lines commented out - otherwise happy for you to merge
________________________________
In renal_capacity_model/model.py<#147 (comment)>:
else: ## prevalent patient
random_number = truncate_2dp(self.rng.uniform(0, 1))
- sampled_time = self.config.time_to_event_curves[
- f"ttd_{patient.dialysis_modality}_initialisation"
- ].loc[random_number, patient.patient_type]
+ sampled_time = (
+ self.config.time_to_event_curves[
+ f"ttd_{patient.dialysis_modality}_initialisation"
+ ].loc[random_number, patient.patient_type]
+ # * self.config.multipliers["ttd"][patient.dialysis_modality]
intentionally commented out?
________________________________
In renal_capacity_model/model.py<#147 (comment)>:
else: ## prevalent patient
random_number = truncate_2dp(self.rng.uniform(0, 1))
- sampled_time = self.config.time_to_event_curves[
- f"ttma_{patient.dialysis_modality}_initialisation"
- ].loc[random_number, patient.patient_type]
+ sampled_time = (
+ self.config.time_to_event_curves[
+ f"ttma_{patient.dialysis_modality}_initialisation"
+ ].loc[random_number, patient.patient_type]
+ ##* self.config.multipliers["ttma"][patient.dialysis_modality]
same here - intentionally commented out?
________________________________
In renal_capacity_model/model.py<#147 (comment)>:
@@ -810,14 +834,20 @@ def start_dialysis_modality(self, patient: Patient) -> Generator:
## sampled_time depends on whether patitent is inicident or not
if patient.patient_flag == "incident":
random_number = truncate_2dp(self.rng.uniform(0, 1))
- sampled_time = self.config.time_to_event_curves[
- f"ttd_{patient.dialysis_modality}"
- ].loc[random_number, patient.patient_type]
+ sampled_time = (
+ self.config.time_to_event_curves[
+ f"ttd_{patient.dialysis_modality}"
+ ].loc[random_number, patient.patient_type]
+ # * self.config.multipliers["ttd"][patient.dialysis_modality]
intentionally commented out?
—
Reply to this email directly, view it on GitHub<#147 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BO7XDG3XB5G6DZMHOXIRUJD4CQJVHAVCNFSM6AAAAACPQ2IMRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOJYHE4DSOBQHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
************************************************************************************** ******************************
This message may contain confidential information. If you are not the intended recipient please:
i) inform the sender that you have received the message in error before deleting it; and
ii) do not disclose, copy or distribute information in this e-mail or take any action in relation to its content (to do so is strictly prohibited and may be unlawful).
Thank you for your co-operation.
NHS.net Connect is the secure email, collaboration and directory service available for all NHS staff in England. NHS.net Connect is approved for exchanging patient data and other sensitive information with NHS.net Connect and other accredited email services.
For more information and to find out how you can switch visit Joining NHS.net Connect – NHS.net Connect Support<https://support.nhs.net/article-categories/joining-nhsmail/>
|
No description provided.