Conversation
…Tx within the sim period
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 86.66% 85.75% -0.92%
==========================================
Files 9 9
Lines 675 688 +13
Branches 76 78 +2
==========================================
+ Hits 585 590 +5
- Misses 81 89 +8
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yiwen-h
left a comment
There was a problem hiding this comment.
Suggest deleting the .csv files in reference that we no longer need (and removing them from the .gitignore file as well, for neatness)
Had a query about why we don't use some of the sampled time to events as they are (and instead truncate to the sim_duration with min) - maybe something I'm not understanding? This happens quite a lot throughout the model
Otherwise - much simpler thank you - the proof is in the pudding though, hopefully validation with real data makes sense.
Closes #146