Skip to content

Logic shift#149

Merged
morganle-48 merged 11 commits intomainfrom
logic-shift
Jan 12, 2026
Merged

Logic shift#149
morganle-48 merged 11 commits intomainfrom
logic-shift

Conversation

@morganle-48
Copy link
Collaborator

Closes #146

@morganle-48 morganle-48 requested a review from yiwen-h as a code owner January 12, 2026 11:36
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 92.98246% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.75%. Comparing base (bf9c0af) to head (633c157).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
renal_capacity_model/model.py 93.78% 9 Missing and 1 partial ⚠️
renal_capacity_model/load_scenario.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   86.66%   85.75%   -0.92%     
==========================================
  Files           9        9              
  Lines         675      688      +13     
  Branches       76       78       +2     
==========================================
+ Hits          585      590       +5     
- Misses         81       89       +8     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest deleting the .csv files in reference that we no longer need (and removing them from the .gitignore file as well, for neatness)

Had a query about why we don't use some of the sampled time to events as they are (and instead truncate to the sim_duration with min) - maybe something I'm not understanding? This happens quite a lot throughout the model

Otherwise - much simpler thank you - the proof is in the pudding though, hopefully validation with real data makes sense.

Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! Have created a couple of issues to build on this:
#153
#152

@morganle-48 morganle-48 merged commit ab4394f into main Jan 12, 2026
6 checks passed
@morganle-48 morganle-48 deleted the logic-shift branch January 12, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic redesign

2 participants