Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 85.89% 85.81% -0.09%
==========================================
Files 9 9
Lines 695 691 -4
Branches 79 78 -1
==========================================
- Hits 597 593 -4
Misses 89 89
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
morganle-48
reviewed
Jan 19, 2026
morganle-48
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
Closes #153
Have compared model results with validation run prior to code changes and they are exactly the same (with exception of mortality in year sim_duration + 1 - previously we were truncating time to death, now we do not). This is mostly just rearranging things to make them clearer.
For example, in config instead of relying on developers remembering that the first value in the list is the shape and the second value is the scale, we are now very explicit about naming what the values are.
before:
after: