Skip to content

Comments

now the model region and centre are updated in the output file automa…#169

Merged
morganle-48 merged 3 commits intomainfrom
track-centre-in-output-file
Feb 10, 2026
Merged

now the model region and centre are updated in the output file automa…#169
morganle-48 merged 3 commits intomainfrom
track-centre-in-output-file

Conversation

@morganle-48
Copy link
Collaborator

…tically when the results are collated

@morganle-48 morganle-48 requested a review from yiwen-h as a code owner February 10, 2026 09:54
@morganle-48
Copy link
Collaborator Author

@yiwen-h I've made a small update the the write to excel functionality so now the results file has the correct region and centre pushed through. I'll update the input files now on Teams as they read in two extra strings.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.77%. Comparing base (69838d0) to head (5df768e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
renal_capacity_model/process_outputs.py 12.50% 7 Missing ⚠️
renal_capacity_model/load_scenario.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   85.81%   84.77%   -1.04%     
==========================================
  Files           9        9              
  Lines         691      703      +12     
  Branches       78       78              
==========================================
+ Hits          593      596       +3     
- Misses         89       98       +9     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one essential change to national config but otherwise works as expected. Have created #170 as a follow up issue

Co-authored-by: YiWen Hon <yiwen.hon1@nhs.net>
@morganle-48 morganle-48 merged commit d1343d3 into main Feb 10, 2026
4 checks passed
@morganle-48 morganle-48 deleted the track-centre-in-output-file branch February 10, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants