editing trial results to align with target trial output#57
Merged
morganle-48 merged 8 commits intomainfrom Oct 1, 2025
Merged
Conversation
Collaborator
Author
|
I don't think this will be the final form of the output - perhaps you can think of a nicer way to store these values in the final table @yiwen-h to make them easier to plot eventually? I am however quite happy I got to the point of taking yearly snapshots and pulling that all together into a snapshot results data frame at the end. NOTE: I've left the original results data frame as is for now, if you like what I've done we can consider dropping it. |
yiwen-h
reviewed
Oct 1, 2025
yiwen-h
approved these changes
Oct 1, 2025
Member
yiwen-h
left a comment
There was a problem hiding this comment.
Works well and I see the aim!
Opportunities for improvement (I'll make issues for them):
- We could move away from naming all the column names individually in process_model_results and process_snapshot_results - too much opportunity for errors as we develop the model and change the things we record in results. Consider just looping through all columns in the df or passing in a dict?
- snapshot_results_df seems to basically repeat everything in results_df - not DRY. let's just store results_df with snapshot_time as well?
- instead of
death_from_{modality}we could just record treatment_modality_at_death or something similar (then we just have one column instead of 6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.