Skip to content

editing trial results to align with target trial output#57

Merged
morganle-48 merged 8 commits intomainfrom
add_results_tracking
Oct 1, 2025
Merged

editing trial results to align with target trial output#57
morganle-48 merged 8 commits intomainfrom
add_results_tracking

Conversation

@morganle-48
Copy link
Collaborator

No description provided.

@morganle-48 morganle-48 marked this pull request as draft September 29, 2025 11:11
@morganle-48 morganle-48 marked this pull request as ready for review September 29, 2025 19:50
@morganle-48
Copy link
Collaborator Author

I don't think this will be the final form of the output - perhaps you can think of a nicer way to store these values in the final table @yiwen-h to make them easier to plot eventually? I am however quite happy I got to the point of taking yearly snapshots and pulling that all together into a snapshot results data frame at the end. NOTE: I've left the original results data frame as is for now, if you like what I've done we can consider dropping it.

@morganle-48 morganle-48 requested a review from yiwen-h September 29, 2025 19:52
Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and I see the aim!

Opportunities for improvement (I'll make issues for them):

  • We could move away from naming all the column names individually in process_model_results and process_snapshot_results - too much opportunity for errors as we develop the model and change the things we record in results. Consider just looping through all columns in the df or passing in a dict?
  • snapshot_results_df seems to basically repeat everything in results_df - not DRY. let's just store results_df with snapshot_time as well?
  • instead of death_from_{modality} we could just record treatment_modality_at_death or something similar (then we just have one column instead of 6.

@morganle-48 morganle-48 merged commit 9081625 into main Oct 1, 2025
1 check passed
@morganle-48 morganle-48 deleted the add_results_tracking branch October 1, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants