Conversation
matt-dray
added
enhancement
DCEW
approved these changes
Oct 25, 2025
Contributor
DCEW
left a comment
DCEW
left a comment
There was a problem hiding this comment.
Code and preview pic look good but reviewing this on my phone so can't fully check. Happy for you to merge though :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #16.
R/mod_plot_rates.Rthat sets up common reactives to feed into each of the modules inR/mod_plot_rates_*.R.theme_rates()function.app_ui()and into the relevant modules.I understand you may not be able to review this; I'll request a differernt reviewer on Monday if so.
Preview (with obfuscated tick labels):