Skip to content

Add procedures and diagnoses tables#32

Merged
matt-dray merged 9 commits intomainfrom
15-tables
Nov 3, 2025
Merged

Add procedures and diagnoses tables#32
matt-dray merged 9 commits intomainfrom
15-tables

Conversation

@matt-dray
Copy link
Contributor

@matt-dray matt-dray commented Oct 28, 2025

Close #15.

  • Added modules for procedures and diagnoses tables (R/mod_table_*.R).
  • Added common R/utils_tables.R and R/fct_tables.R to wrangle encounters data and generate summary tables, respectively.
  • Consolidated entable_procedures()/entable_diagnoses() into entable_encounters() (for future consolidation ideas, see Consolidate code for procedures and diagnoses #31).
  • Adjusted the app layout to insert the tables.

@tomjemmett: added you for review in lieu of Claire, if possible. This PR contributes to the creation of an MVP (#5) that apes the inputs app, basically. We're working quicklyish on this, so it's definitely not perfect for now (e.g. more functions could be consolidated, like in #31). The current state is not yet deployed (blocked by #8 currently), but I'd be interested to know if it runs locally for you. Happy to talk this through tomorrow (Fri 31). Removed Tom from reviewer list.

@matt-dray matt-dray added this to the v0.2.0 milestone Oct 28, 2025
@matt-dray matt-dray self-assigned this Oct 28, 2025
@matt-dray matt-dray requested a review from DCEW as a code owner October 28, 2025 18:20
@matt-dray matt-dray added enhancement New feature or request priority: must MoSCoW priority labels Oct 28, 2025
@matt-dray matt-dray requested review from tomjemmett and removed request for tomjemmett October 30, 2025 17:45
Copy link
Contributor

@DCEW DCEW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Strategy comment. Also (although may be planned for later/minutiae) - consider angle=90 for rates x-axis for improved visibility, more clear axis labels (e.g. should we make it v clear where rates are age/sex standardised? Rates per 10000?)

@matt-dray
Copy link
Contributor Author

matt-dray commented Nov 3, 2025

Re chart improvement: I think that comes towards the end as I start to put these functions into a package/introduce common theming.

Re axis labelling: this requires some config updates, given there's different labels depending on the TPMA, of course. That should probably be part of this PR anyway, actually. I'll add it in. See below.

@matt-dray
Copy link
Contributor Author

In fact, I'm not going to add anything more to this particular PR, @DCEW.

I have updated the interface to use 'TPMA' rather than 'strategy', but we'll:

@DCEW
Copy link
Contributor

DCEW commented Nov 3, 2025 via email

@matt-dray matt-dray requested a review from DCEW November 3, 2025 12:04
@matt-dray matt-dray merged commit e4c160d into main Nov 3, 2025
2 checks passed
@matt-dray matt-dray deleted the 15-tables branch November 3, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: must MoSCoW priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add procedures and diagnoses tables

2 participants