Conversation
DCEW
left a comment
There was a problem hiding this comment.
See Strategy comment. Also (although may be planned for later/minutiae) - consider angle=90 for rates x-axis for improved visibility, more clear axis labels (e.g. should we make it v clear where rates are age/sex standardised? Rates per 10000?)
|
Re chart improvement: I think that comes towards the end as I start to put these functions into a package/introduce common theming. Re axis labelling: this requires some config updates, given there's different labels depending on the TPMA, of course. |
|
In fact, I'm not going to add anything more to this particular PR, @DCEW. I have updated the interface to use 'TPMA' rather than 'strategy', but we'll:
|
|
[like] WELSH, Claire (NHS MIDLANDS AN... reacted to your message:
…________________________________
From: Matt Dray ***@***.***>
Sent: Monday, November 3, 2025 11:36:53 AM
To: The-Strategy-Unit/tpma-explorer ***@***.***>
Cc: WELSH, Claire (NHS MIDLANDS AND LANCASHIRE COMMISSIONING SUPPORT UNIT) ***@***.***>; Mention ***@***.***>
Subject: Re: [The-Strategy-Unit/tpma-explorer] Add procedures and diagnoses tables (PR #32)
This message originated from outside of NHS.net Connect. Please do not click links or open attachments unless you recognise the sender and know the content is safe.
[https://avatars.githubusercontent.com/u/18232097?s=20&v=4]matt-dray left a comment (The-Strategy-Unit/tpma-explorer#32)<#32 (comment)>
In fact, I'm not going to add anything more to this particular PR, @DCEW<https://github.com/DCEW>.
I have updated the interface to use 'TPMA' rather than 'strategy', but we'll:
* deal with config in #33<#33>, which will e.g. handle axis label names
* handle general plot/design improvements in #30<#30>, which will handle things like axis rotations (and i realise that's trickier said than done, becuase the axes need to line up across the funnel and boxplot as well)
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A22Y5B3RRVEOM33Y444JROD32445LAVCNFSM6AAAAACKO7SY4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOBQGA4DCMBTGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
************************************************************************************** ******************************
This message may contain confidential information. If you are not the intended recipient please:
i) inform the sender that you have received the message in error before deleting it; and
ii) do not disclose, copy or distribute information in this e-mail or take any action in relation to its content (to do so is strictly prohibited and may be unlawful).
Thank you for your co-operation.
NHS.net Connect is the secure email, collaboration and directory service available for all NHS staff in England. NHS.net Connect is approved for exchanging patient data and other sensitive information with NHS.net Connect and other accredited email services.
For more information and to find out how you can switch visit Joining NHS.net Connect – NHS.net Connect Support<https://support.nhs.net/article-categories/joining-nhsmail/>
|
Close #15.
R/mod_table_*.R).R/utils_tables.RandR/fct_tables.Rto wrangle encounters data and generate summary tables, respectively.entable_procedures()/entable_diagnoses()intoentable_encounters()(for future consolidation ideas, see Consolidate code for procedures and diagnoses #31).@tomjemmett: added you for review in lieu of Claire, if possible. This PR contributes to the creation of an MVP (#5) that apes the inputs app, basically. We're working quicklyish on this, so it's definitely not perfect for now (e.g. more functions could be consolidated, like in #31). The current state is not yet deployed (blocked by #8 currently), but I'd be interested to know if it runs locally for you. Happy to talk this through tomorrow (Fri 31).Removed Tom from reviewer list.