Conversation
matt-dray
added
enhancement
DCEW
approved these changes
Dec 3, 2025
Contributor
DCEW
left a comment
DCEW
left a comment
There was a problem hiding this comment.
Still unable to see all plots locally - only trend. Would be good to understand why, but in the mean time, code looks sensible so approving given time constraints.
Contributor
Author
|
Hm, the three trend charts are all ultimately fed by the same data from the same module. I'll ask another member of the team to run it locally to see if they have the same issue. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #35, close #52, close #38 (parent).
data-raw/wrangling script).DESCRIPTIONdependencies;.lintrand.Rbuildignoreto ignoredata-raw/; redocumented the package.It works for now, but there's room for refactoring (covered by e.g. #40, #27, etc). Happy to walk it through.