Skip to content

[fix/docs]: improve the Jump Game algorithm #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2024
Merged

[fix/docs]: improve the Jump Game algorithm #2514

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
037b28b
[fix/docs]: improve the Jump Game algorithm
Panquesito7 Jul 26, 2023
4a3e7bb
fix: pass `index` by reference and `const` it
Panquesito7 Jul 26, 2023
9bbb2fd
fix: use previous algorithm
Panquesito7 Jul 26, 2023
44e4c47
chore: apply suggestions from code review
Panquesito7 Jul 28, 2023
7ef56d9
Merge branch 'master' into improve_jumpgame
Panquesito7 Jan 16, 2024
9e91c18
Merge branch 'master' into improve_jumpgame
realstealthninja Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions greedy_algorithms/jump_game.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ namespace greedy_algorithms {
* @returns false if the index can NOT be reached
*/
template <typename T>
bool can_jump(const std::vector<T> &nums, const int &index = 1) {
const int size = nums.size() + 1 - nums[index];
if (nums[index] >= size) { // `>=` because the number can be higher than the size of the array.
return true;
bool can_jump(const std::vector<T> &nums) {
size_t lastPos = nums.size() - 1;
for (int i = nums.size() - 1; i >= 0; i--) {
if (i + nums[i] >= lastPos) {
lastPos = i;
}
}
return false;
return lastPos == 0;
}
} // namespace greedy_algorithms

Expand All @@ -67,11 +69,11 @@ static void test() {
assert(greedy_algorithms::can_jump(nums) == true);

// 4th test
nums = { 4, 2, 8, 9, 6 };
nums = { 1, 0, 5, 8, 12 };
assert(greedy_algorithms::can_jump(nums) == false);

// 5th test
nums = { 7, 4, 8, 13, 2, 11 };
nums = {2, 1, 4, 7};
assert(greedy_algorithms::can_jump(nums) == true);

std::cout << "All tests have successfully passed!\n";
Expand Down