-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Rework on Stack Array Data Structure #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+166
−49
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
759d532
ref: rework on stack array data structure
sozelfist 940ac14
chore(docs): add `namespace` docstring
sozelfist e741146
chore: add `std::out_of_range` exception and test cases when stack is…
sozelfist 19fc4b4
ref: add `full` and `empty` methods
sozelfist 9c55a9a
ref: improve stack array implementation
sozelfist ee40cbc
Merge branch 'master' into ds/stack
sozelfist 2e79385
fix: remove comparision to true from asserts
realstealthninja adf14bb
chore: remove `stack.hpp`
sozelfist a027a13
fix: revert
realstealthninja 1b8b60f
Update data_structures/stack_using_array.cpp
realstealthninja 548085b
docs: add namespace comment
realstealthninja 7c442b8
Merge branch 'master' into ds/stack
sozelfist 7ae10a6
chore: remove redundant line in docstring of `empty` method
sozelfist b0210e1
Merge branch 'master' into ds/stack
realstealthninja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,176 @@ | ||
#include <cassert> | ||
#include <iostream> | ||
#include <memory> | ||
#include <stdexcept> | ||
|
||
int *stack; | ||
int stack_idx = 0, stack_size; | ||
namespace data_structures { | ||
realstealthninja marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/** | ||
* @brief Class representation of a stack | ||
* @tparam T The type of the elements in the stack | ||
*/ | ||
template <typename T> | ||
class Stack { | ||
private: | ||
std::unique_ptr<T[]> stack; ///< Smart pointer to the stack array | ||
int stackSize; ///< Maximum size of the stack | ||
int stackIndex; ///< Index pointing to the top element of the stack | ||
|
||
void push(int x) { | ||
if (stack_idx == stack_size) { | ||
std::cout << "\nOverflow"; | ||
} else { | ||
stack[stack_idx++] = x; | ||
public: | ||
/** | ||
* @brief Constructs a new Stack object | ||
* | ||
* @param size Maximum size of the stack | ||
*/ | ||
Stack(int size) : stackSize(size), stackIndex(-1), stack(new T[size]) {} | ||
|
||
/** | ||
* @brief Checks if the stack is full | ||
* | ||
* @return true if the stack is full, false otherwise | ||
*/ | ||
bool full() const { return stackIndex == stackSize - 1; } | ||
|
||
/** | ||
* @brief Checks if the stack is empty | ||
* | ||
sozelfist marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* @return true if the stack is empty, false otherwise | ||
*/ | ||
bool empty() const { return stackIndex == -1; } | ||
|
||
/** | ||
* @brief Pushes an element onto the stack | ||
* | ||
* @param element Element to push onto the stack | ||
*/ | ||
void push(T element) { | ||
if (full()) { | ||
throw std::out_of_range("Stack overflow"); | ||
} else { | ||
stack[++stackIndex] = element; | ||
} | ||
} | ||
} | ||
|
||
void pop() { | ||
if (stack_idx == 0) { | ||
std::cout << "\nUnderflow"; | ||
} else { | ||
std::cout << "\n" << stack[--stack_idx] << " deleted"; | ||
/** | ||
* @brief Pops an element from the stack | ||
* | ||
* @return The popped element | ||
* @throws std::out_of_range if the stack is empty | ||
*/ | ||
T pop() { | ||
if (empty()) { | ||
throw std::out_of_range("Stack underflow"); | ||
} | ||
return stack[stackIndex--]; | ||
} | ||
|
||
/** | ||
* @brief Displays all elements in the stack | ||
*/ | ||
void show() const { | ||
for (int i = 0; i <= stackIndex; i++) { | ||
std::cout << stack[i] << "\n"; | ||
} | ||
} | ||
} | ||
|
||
void show() { | ||
for (int i = 0; i < stack_idx; i++) { | ||
std::cout << stack[i] << "\n"; | ||
/** | ||
* @brief Displays the topmost element of the stack | ||
* | ||
* @return The topmost element of the stack | ||
* @throws std::out_of_range if the stack is empty | ||
*/ | ||
T topmost() const { | ||
if (empty()) { | ||
throw std::out_of_range("Stack underflow"); | ||
} | ||
return stack[stackIndex]; | ||
} | ||
} | ||
|
||
void topmost() { std::cout << "\nTopmost element: " << stack[stack_idx - 1]; } | ||
void bottom() { std::cout << "\nBottom element: " << stack[0]; } // If we need access to first element without using pop command | ||
int main() { | ||
std::cout << "\nEnter stack_size of stack : "; | ||
std::cin >> stack_size; | ||
stack = new int[stack_size]; | ||
int ch, x; | ||
do { | ||
std::cout << "\n0. Exit"; | ||
std::cout << "\n1. Push"; | ||
std::cout << "\n2. Pop"; | ||
std::cout << "\n3. Print"; | ||
std::cout << "\n4. Print topmost element:"; | ||
std::cout << "\n5. Print Bottom element:"; | ||
std::cout << "\nEnter Your Choice : "; | ||
std::cin >> ch; | ||
if (ch == 1) { | ||
std::cout << "\nInsert : "; | ||
std::cin >> x; | ||
push(x); | ||
} else if (ch == 2) { | ||
pop(); | ||
} else if (ch == 3) { | ||
show(); | ||
} else if (ch == 4) { | ||
topmost(); | ||
} else if(ch == 5) { | ||
bottom(); | ||
/** | ||
* @brief Displays the bottom element of the stack | ||
* | ||
* @return The bottom element of the stack | ||
* @throws std::out_of_range if the stack is empty | ||
*/ | ||
T bottom() const { | ||
if (empty()) { | ||
throw std::out_of_range("Stack underflow"); | ||
} | ||
} while (ch != 0); | ||
return stack[0]; | ||
} | ||
}; | ||
} // namespace data_structures | ||
|
||
/** | ||
* @brief Self-test implementations | ||
* @returns void | ||
*/ | ||
static void test() { | ||
data_structures::Stack<int> stack(5); | ||
|
||
// Test empty and full operations | ||
assert(stack.empty() == true); | ||
realstealthninja marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
assert(stack.full() == false); | ||
realstealthninja marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
delete[] stack; | ||
// Test pushing elements and checking topmost | ||
stack.push(10); | ||
assert(stack.topmost() == 10); | ||
|
||
sozelfist marked this conversation as resolved.
Show resolved
Hide resolved
|
||
stack.push(20); | ||
assert(stack.topmost() == 20); | ||
|
||
stack.push(30); | ||
stack.push(40); | ||
stack.push(50); | ||
assert(stack.full() == true); | ||
realstealthninja marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
// Test stack overflow | ||
try { | ||
stack.push(60); | ||
} catch (const std::out_of_range& e) { | ||
assert(std::string(e.what()) == "Stack overflow"); | ||
} | ||
|
||
// Test popping elements | ||
assert(stack.pop() == 50); | ||
assert(stack.pop() == 40); | ||
assert(stack.pop() == 30); | ||
|
||
// Check topmost and bottom elements | ||
assert(stack.topmost() == 20); | ||
assert(stack.bottom() == 10); | ||
|
||
assert(stack.pop() == 20); | ||
assert(stack.pop() == 10); | ||
|
||
assert(stack.empty() == true); | ||
realstealthninja marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
assert(stack.full() == false); | ||
realstealthninja marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
// Test stack underflow | ||
try { | ||
stack.pop(); | ||
} catch (const std::out_of_range& e) { | ||
assert(std::string(e.what()) == "Stack underflow"); | ||
} | ||
|
||
try { | ||
stack.topmost(); | ||
} catch (const std::out_of_range& e) { | ||
assert(std::string(e.what()) == "Stack underflow"); | ||
} | ||
|
||
try { | ||
stack.bottom(); | ||
} catch (const std::out_of_range& e) { | ||
assert(std::string(e.what()) == "Stack underflow"); | ||
} | ||
} | ||
|
||
/** | ||
* @brief Main function | ||
* @returns 0 on exit | ||
*/ | ||
int main() { | ||
test(); // run self-test implementations | ||
std::cout << "All tests passed!" << std::endl; | ||
return 0; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.