Skip to content

Conversation

JohhannasReyn
Copy link

Fix Segmentation fault due to the Graph being passed by value, and there not being a copy constructor. Adding the & for the Graph parameter changes the passing of the parameter to be passed by reference and circumvents the segmentation fault.

Description of Change

Checklist

  • [x ] Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Added an '&' to pass the Graph parameter by reference to avoid the segmentation fault that was being produced prior to this change.

Fix Segmentation fault do to graph being passed by object and there not being a copy constructor. Adding the '&' for the Graph parameter changes the passing of the parameter to pass by reference, thus avoiding the segmentation fault.
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I dont think this prevents all the segfaults though

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants