Skip to content

Conversation

Divyansh-jain2
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@realstealthninja
Copy link
Collaborator

have you checked all the tests?

@realstealthninja
Copy link
Collaborator

might need to add this before cmath

#define _USE_MATH_DEFINES
#include <cmath>

@realstealthninja
Copy link
Collaborator

@Divyansh-jain2 there is just a single conversation to resolve to get this merged!

@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 4, 2024
@realstealthninja realstealthninja changed the title chore: changed PI variable value from 3.14 to M_PI chore: use M_PI instead of PI parameter Oct 4, 2024
@realstealthninja realstealthninja merged commit c56496d into TheAlgorithms:master Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting modification Do not merge until modifications are made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants