Skip to content

feat: Add hemi-sphere area algorithm #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: Add hemi-sphere area algorithm #2767

merged 4 commits into from
Oct 7, 2024

Conversation

HarshilShah1804
Copy link
Contributor

Description of Change

Added the area of hemi-sphere algorithm with test to math/area.cpp

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes Oct 5, 2024
View reviewed changes
@realstealthninja realstealthninja added awaiting modification Do not merge until modifications are made enhancement New feature or request labels Oct 5, 2024
@realstealthninja
Copy link
Collaborator

hey thank you for your contribution! please let me know if this is for hacktoberfest!

@HarshilShah1804 @realstealthninja
Update math/area.cpp
2a05188 
Co-authored-by: realstealthninja <[email protected]>
@HarshilShah1804
Copy link
Contributor Author

hey thank you for review.

Yes, this was for hacktoberfest.

HarshilShah1804
HarshilShah1804 commented Oct 5, 2024
View reviewed changes
Copy link
Contributor Author

@HarshilShah1804 HarshilShah1804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed your suggestion.

realstealthninja
realstealthninja approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderfully done! Thank you so much for this contribution ill mark this as hacktoberfest-accepted. I wish you the best of luck!

@realstealthninja realstealthninja added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest approved Approved; waiting for merge and removed awaiting modification Do not merge until modifications are made labels Oct 5, 2024
@realstealthninja realstealthninja merged commit b957b1d into TheAlgorithms:master Oct 7, 2024
6 checks passed
@HarshilShah1804 HarshilShah1804 deleted the Harshil branch October 7, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarshilShah1804 @realstealthninja