Skip to content

Conversation

Maahmoudezzat
Copy link

Description of Change

Checklist

A well-formatted and organized Job sequencing algorithm explanation & implementation added applying a greedy approach using the priority_queue data structure.

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing. This has a very nicely written header.
Please do read the contributing.md file and fix the documentation issues with the functions, headers. Please also add tests n a separate function

@realstealthninja realstealthninja added awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly labels Oct 9, 2024
@Maahmoudezzat
Copy link
Author

Thanks for the review.
I have do the following:

  • A proper documentation for functions and headers as mentioned in the guide.
  • Added tests in the main.

@Maahmoudezzat
Copy link
Author

@realstealthninja Hey, I'm waiting for your reveiw.

"xloctime": "cpp",
"xmemory": "cpp",
"xstddef": "cpp",
"xstring": "cpp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes to this file

*
* @param arr array fo Jobs
* @param n number of the jobs in the array
* @returns vector of 'char' including the IDs of jobs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template parameter N should be documented

 @ tparam N <describe N> 

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Dec 10, 2024
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants