feat: add non-preemptive SJF scheduling #2801

LakshmiSrikumar · 2024-10-09T13:14:49Z

Description of Change

Non pre-emptive SJF Scheduling algorithm
Added C++ implementation of SJF scheduling algorithm in the directory cpu_scheduling/

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja · 2024-10-09T13:16:49Z

put it in some directory instead of the root directory.
you haven't checked any of the checkboxes in your pull request
please add a description to the pr

realstealthninja · 2024-10-09T13:17:31Z

https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#Commit-Guidelines
read this contributing file thank you!

LakshmiSrikumar · 2024-10-09T13:44:38Z

@realstealthninja I have done the following

LakshmiSrikumar · 2024-10-10T07:08:29Z

@realstealthninja Could you please review the PR ? And could the hacktober label be put ?

realstealthninja

Please move this algorithm to cpu_scheduling/ since that seems appropriate

non_preemptive_sjf_scheduling.cpp

Co-authored-by: realstealthninja <[email protected]>

non_preemptive_sjf_scheduling.cpp

Co-authored-by: realstealthninja <[email protected]>

@realstealthninja

I have done the necessary changes. The test function will generate 10 different testcases in which it will print the before and after the SJF scheduling. @realstealthninja Kindly review the PR and please accept it.

…rikumar/C-Plus-Plus into LakshmiSrikumar-patch-1

LakshmiSrikumar · 2024-10-12T05:40:47Z

I have done the necessary changes.

changed the file directory to /cpu_scheduling_algorithms
Now, the test function will generate 10 different testcases in which it will print the before and after the SJF scheduling for each test case.

@realstealthninja Kindly review the PR and please accept it.

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp

Co-authored-by: realstealthninja <[email protected]>

…rikumar/C-Plus-Plus into LakshmiSrikumar-patch-1

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp

LakshmiSrikumar · 2024-10-16T10:21:24Z

@realstealthninja could you please approve the repo ?

realstealthninja

Lgtm!

LakshmiSrikumar · 2024-10-17T17:57:48Z

The approved label is not added

LakshmiSrikumar · 2024-10-17T18:02:09Z

the approved label is not added and the hacktober has not accepted the repo. Could you tell why ?

…

On Thu, Oct 17, 2024 at 9:07 PM realstealthninja ***@***.***> wrote: ***@***.**** approved this pull request. Lgtm! — Reply to this email directly, view it on GitHub <#2801 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBVMSXJBSFNZY5AOPNB33ZTZ37KTDAVCNFSM6AAAAABPUQSYHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVGYYTINZTGE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

realstealthninja · 2024-10-19T09:36:25Z

the approved label is not added and the hacktober has not accepted the repo. Could you tell why ?
…
On Thu, Oct 17, 2024 at 9:07 PM realstealthninja @.> wrote: @.* approved this pull request. Lgtm! — Reply to this email directly, view it on GitHub <#2801 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBVMSXJBSFNZY5AOPNB33ZTZ37KTDAVCNFSM6AAAAABPUQSYHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVGYYTINZTGE . You are receiving this because you modified the open/close state.Message ID: @.***>

I'm very sorry. I've added it now! ❤️ thanks again for contributing

dynamic_programming/unbounded_0_1_knapsack.cpp

Create non_preemptive_sjf_scheduling.cpp

80127bb

LakshmiSrikumar requested review from Panquesito7 and realstealthninja as code owners October 9, 2024 13:14

Merge branch 'master' into LakshmiSrikumar-patch-1

f99fefa

realstealthninja added invalid awaiting modification Do not merge until modifications are made labels Oct 9, 2024

realstealthninja added the hacktoberfest label Oct 10, 2024

realstealthninja requested changes Oct 10, 2024

View reviewed changes

realstealthninja removed the invalid label Oct 10, 2024

LakshmiSrikumar and others added 5 commits October 10, 2024 18:57

Update non_preemptive_sjf_scheduling.cpp

ad156c9

Co-authored-by: realstealthninja <[email protected]>

Update non_preemptive_sjf_scheduling.cpp

b8e1b84

Co-authored-by: realstealthninja <[email protected]>

Update non_preemptive_sjf_scheduling.cpp

d00becf

Co-authored-by: realstealthninja <[email protected]>

Merge branch 'TheAlgorithms:master' into LakshmiSrikumar-patch-1

8d6f3c1

added a vector to store and print the final result

7af8d8a

realstealthninja requested changes Oct 11, 2024

View reviewed changes

non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved

non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved

LakshmiSrikumar and others added 3 commits October 11, 2024 10:43

Merge branch 'TheAlgorithms:master' into LakshmiSrikumar-patch-1

c126f71

Update non_preemptive_sjf_scheduling.cpp

062a78c

Co-authored-by: realstealthninja <[email protected]>

Update non_preemptive_sjf_scheduling.cpp

77402aa

Co-authored-by: realstealthninja <[email protected]>

LakshmiSrikumar requested a review from realstealthninja October 11, 2024 05:57

LakshmiSrikumar added 3 commits October 12, 2024 11:04

Create non_preemptive_sjf_scheduling.cpp

9d9b51f

I have done the necessary changes. The test function will generate 10 different testcases in which it will print the before and after the SJF scheduling. @realstealthninja Kindly review the PR and please accept it.

Merge branch 'LakshmiSrikumar-patch-1' of https://github.com/LakshmiS…

f1338b0

…rikumar/C-Plus-Plus into LakshmiSrikumar-patch-1

Delete non_preemptive_sjf_scheduling.cpp

4404bbb

realstealthninja requested changes Oct 12, 2024

View reviewed changes

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved

LakshmiSrikumar and others added 2 commits October 12, 2024 14:06

Update cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp

ccb3f07

Co-authored-by: realstealthninja <[email protected]>

Update non_preemptive_sjf_scheduling.cpp

cbbfc88

LakshmiSrikumar added 3 commits October 13, 2024 17:17

Update non_preemptive_sjf_scheduling.cpp

6ebca75

Merge branch 'LakshmiSrikumar-patch-1' of https://github.com/LakshmiS…

6622a64

…rikumar/C-Plus-Plus into LakshmiSrikumar-patch-1

Merge branch 'master' into LakshmiSrikumar-patch-1

258c6fd

realstealthninja requested changes Oct 13, 2024

View reviewed changes

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved

Update non_preemptive_sjf_scheduling.cpp

c195a7e

LakshmiSrikumar requested a review from realstealthninja October 14, 2024 05:36

Merge branch 'master' into LakshmiSrikumar-patch-1

87e162c

realstealthninja requested changes Oct 15, 2024

View reviewed changes

cpu_scheduling_algorithms/non_preemptive_sjf_scheduling.cpp Show resolved Hide resolved

LakshmiSrikumar closed this Oct 16, 2024

LakshmiSrikumar reopened this Oct 16, 2024

LakshmiSrikumar requested a review from realstealthninja October 17, 2024 06:30

realstealthninja previously approved these changes Oct 17, 2024

View reviewed changes

realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made labels Oct 19, 2024

realstealthninja changed the title ~~Implementation of Non-preemptive SJF scheduling~~ feat: add non-preemptive SJF scheduling Oct 19, 2024

realstealthninja and others added 2 commits October 31, 2024 10:44

Merge branch 'master' into LakshmiSrikumar-patch-1

57e670c

clang-format and clang-tidy fixes for 57e670c

a824301

github-actions bot dismissed realstealthninja’s stale review via a824301 October 31, 2024 05:14

realstealthninja previously approved these changes Nov 3, 2024

View reviewed changes

Merge branch 'master' into LakshmiSrikumar-patch-1

9fdc8d8

realstealthninja dismissed their stale review via 9fdc8d8 November 6, 2024 16:13

realstealthninja reviewed Nov 7, 2024

View reviewed changes

dynamic_programming/unbounded_0_1_knapsack.cpp Outdated Show resolved Hide resolved

dynamic_programming/unbounded_0_1_knapsack.cpp Outdated Show resolved Hide resolved

realstealthninja added 2 commits November 7, 2024 05:44

chore: remove spaces

c9e9d3b

Update dynamic_programming/unbounded_0_1_knapsack.cpp

0dbd473

realstealthninja merged commit 48743d3 into TheAlgorithms:master Nov 7, 2024

Uh oh!

feat: add non-preemptive SJF scheduling #2801

feat: add non-preemptive SJF scheduling #2801

Conversation

LakshmiSrikumar commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Uh oh!

realstealthninja commented Oct 9, 2024

Uh oh!

realstealthninja commented Oct 9, 2024

Uh oh!

LakshmiSrikumar commented Oct 9, 2024

Uh oh!

LakshmiSrikumar commented Oct 10, 2024

Uh oh!

realstealthninja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshmiSrikumar commented Oct 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshmiSrikumar commented Oct 16, 2024

Uh oh!

realstealthninja left a comment

Choose a reason for hiding this comment

Uh oh!

LakshmiSrikumar commented Oct 17, 2024

Uh oh!

LakshmiSrikumar commented Oct 17, 2024 via email

Uh oh!

realstealthninja commented Oct 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshmiSrikumar commented Oct 9, 2024 •

edited

Loading