fix: remove potential segv from factorial_memoization
#2994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
force-pushed
the
fix_factorial_memoization
branch
from
dcc39b5 to
180b83e
Compare
vil02
force-pushed
the
fix_factorial_memoization
branch
from
180b83e to
11347b2
Compare
vil02
changed the title
factorial_memoization
realstealthninja
approved these changes
Sep 5, 2025
8 tasks
realstealthninja
pushed a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…ization.cpp` (TheAlgorithms#2994)" This reverts commit 1426fa4.
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…ization.cpp` (TheAlgorithms#2994)" This reverts commit 1426fa4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
factorial_memoization.cpphas a potential segmentation fault: consider the call likefact_recursion(1000).This PR fixes that and additionally removes one global variable. @git5v: please have a look.
Additionally I decided to remove the
mathnamespace, because it is a cpp file with amainfunction anyway.@realstealthninja: regarding the doc-strings: we have different opinion about them. If you will find some additional one useful, please just push it to my branch.
Checklist
Notes:
Removes a potential segv.