Add Sliding Window XOR algorithm in C++ with test cases #3023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataWorshipper
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
requested changes
Oct 2, 2025
| #include <cassert> /// for assert | ||
| #include <cstdint> | ||
| #include <iostream> /// for IO operations | ||
| #include <vector> |
There was a problem hiding this comment.
Suggested change
| #include <vector> | |
| #include <vector> /// for std::vector |
Comment on lines
39
to
41
| * @param a Multiplier in array generation | ||
| * @param b Increment in array generation | ||
| * @param c Modulo in array generation |
There was a problem hiding this comment.
These variable names could be longer.
There was a problem hiding this comment.
These variables were in the problem statement ,i think it would be intuitive for the user who is following the problem statement
Comment on lines
67
to
68
| std::uint64_t l = 0; // Left pointer of sliding window | ||
| std::uint64_t r = 0; // Right pointer of sliding window |
There was a problem hiding this comment.
Could name these to be left and right, respectively.
| int main() { | ||
| test(); // run self-test implementations | ||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
|
Hello ,so i have refactored the variable names and added the changes that you requested ,could you take a look at it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request adds a C++ implementation of the Sliding Window XOR problem to the Bit Manipulation section.
The algorithm calculates the bitwise XOR of every window of size
kin an array ofnintegers generated using the recurrence relation:It maintains a sliding window of size k using two pointers, efficiently computing the cumulative XOR of all windows in O(n) time with O(n) space.
The submission is self-contained, with detailed Doxygen documentation and a test() function that includes multiple verified test cases to ensure correctness.
Checklist