-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Rabin karp algo #5425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabin karp algo #5425
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
============================================
+ Coverage 52.05% 52.13% +0.07%
- Complexity 3240 3249 +9
============================================
Files 524 525 +1
Lines 15181 15207 +26
Branches 2888 2897 +9
============================================
+ Hits 7903 7928 +25
Misses 6955 6955
- Partials 323 324 +1 ☔ View full report in Codecov by Sentry. |
Hey regarding the previous comment on my previous closed PR @alxkm , my implementation improves the Rabin-Karp algorithm by more modularity with well-structured methods, making the code more readable and maintainable. It includes input error handlings to prevent runtime errors from edge cases like empty strings.. I faced small small errors after committing so there are more commits :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove main
method, and add test cases separately.
There are already two implementations: |
👀why there are two implementations then? just asking 😀 |
No idea.
No. EDIT: Since you have a fresh knowledge about Rabin-Karp algorithm feel free to take care of this duplication, i.e.:
|
Yeah, you can improve the existing algo, I can not add this algo, it already exists. |
clang-format -i --style=file path/to/your/file.java