Skip to content

Conversation

nahcol10
Copy link

@nahcol10 nahcol10 commented Oct 10, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.

Project coverage is 60.63%. Comparing base (ba3d3bf) to head (bf32eda).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...datastructures/lists/LinkedListCycleDetection.java 0.00% 34 Missing ⚠️
...thms/datastructures/graphs/TopologicalSortBFS.java 0.00% 31 Missing ⚠️
...thms/datastructures/graphs/TopologicalSortDFS.java 0.00% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5710      +/-   ##
============================================
- Coverage     60.99%   60.63%   -0.36%     
  Complexity     3917     3917              
============================================
  Files           563      566       +3     
  Lines         16006    16101      +95     
  Branches       3074     3095      +21     
============================================
  Hits           9763     9763              
- Misses         5834     5929      +95     
  Partials        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An implementation already exists here

public final class TopologicalSort {
, is it different from yours? Please remove main, add JUnit tests, and fix PR checks

@nahcol10 nahcol10 closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants