feat: add Jarvis-March algorithm #5777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5777 +/- ##
============================================
+ Coverage 65.99% 66.07% +0.07%
- Complexity 4395 4412 +17
============================================
Files 603 604 +1
Lines 16799 16835 +36
Branches 3226 3236 +10
============================================
+ Hits 11086 11123 +37
Misses 5266 5266
+ Partials 447 446 -1 ☔ View full report in Codecov by Sentry. |
saahil-mahato
requested review from
BamaCharanChhandogi,
alxkm,
siriak,
vil02 and
yanglbme
as code owners
alxkm
requested changes
Oct 22, 2024
| /** | ||
| * Represents a point in 2D space with x and y coordinates. | ||
| */ | ||
| static class Point { |
There was a problem hiding this comment.
This class can be removed, as similar class already exist here:
https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/Point.java
So will be better to use it.
| * @param c the third point | ||
| * @return true if it makes a left turn, false otherwise | ||
| */ | ||
| private static boolean isLeftTurn(Point a, Point b, Point c) { |
There was a problem hiding this comment.
These methods looks like utility methods. So can be moved or to Point class there or utility class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java