Skip to content

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 14, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.42%. Comparing base (bca8d0e) to head (8624313).
⚠️ Report is 316 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5818      +/-   ##
============================================
+ Coverage     72.40%   72.42%   +0.01%     
- Complexity     4983     4985       +2     
============================================
  Files           653      654       +1     
  Lines         17574    17597      +23     
  Branches       3386     3387       +1     
============================================
+ Hits          12724    12744      +20     
- Misses         4371     4372       +1     
- Partials        479      481       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hardvan Hardvan marked this pull request as ready for review October 14, 2024 13:46
@Hardvan Hardvan requested a review from siriak October 29, 2024 04:56
for (Task task : tasks) {
scheduledOrder.add(task.name);
currentTime += task.executionTime;
totalEnergyConsumption += currentTime * task.energyConsumption;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is consumed energy linearly proportional to the current time? The process should define when it consumes how much energy, or it should be defined somehow else. Please provide references where this algorithm is explained.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 30, 2024
Copy link

github-actions bot commented Dec 7, 2024

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants