Skip to content

Conversation

Shreya123714
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.44%. Comparing base (a676ebc) to head (e909b40).
⚠️ Report is 237 commits behind head on master.

Files with missing lines Patch % Lines
...java/com/thealgorithms/audiofilters/EMAFilter.java 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6075      +/-   ##
============================================
+ Coverage     73.42%   73.44%   +0.01%     
- Complexity     5078     5081       +3     
============================================
  Files           656      657       +1     
  Lines         17617    17632      +15     
  Branches       3394     3396       +2     
============================================
+ Hits          12936    12950      +14     
  Misses         4180     4180              
- Partials        501      502       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Removed Trailing spaces from EMAFilter.java
Removed trailing spaces from EMAFilterTest.java
Tried Removing Trailing spaces from EMAFilter.java
Removed Extra braces
@Shreya123714
Copy link
Contributor Author

Hi @yanglbme, @siriak, @vil02, @BamaCharanChhandogi, @alxkm, I’ve added an EMA filter implementation and some test cases in Java, but I'm running into a build error, could you please take a look when you have a moment? I’d appreciate any feedback or suggestions on how to resolve this.
Thank you so much! 🙏

Formatted the EMAFilterTest.java
Corrected the Assertion in EMAFilterTest.java
Remove trailing spaces
@siriak
Copy link
Member

siriak commented Oct 31, 2024

This is the error
image

@Shreya123714
Copy link
Contributor Author

@siriak , Thank you :)
Resolved it 🥹.. Done

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) November 1, 2024 08:34
@siriak siriak merged commit 7b962a4 into TheAlgorithms:master Nov 1, 2024
6 checks passed
@Shreya123714
Copy link
Contributor Author

Looks good, thanks!

Thank you, I will add more features to the repo in 2 or 3 days, I am planning to add, Fuzzy set and Fuzzy inference system as well 😄🌌🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants