Skip to content

Refactor and enhance the 'Upper' class for better functionality and robustness #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Refactor and enhance the 'Upper' class for better functionality and robustness #6118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
823fd2d
Refactor and enhance the 'Upper' class for better functionality and r…
paren-thesis Jan 7, 2025
bcdf75d
Merge branch 'master' into master
paren-thesis Jan 11, 2025
7b12e46
Merge branch 'master' into master
siriak Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/main/java/com/thealgorithms/strings/Upper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,19 @@ public static void main(String[] args) {
* @return the {@code String}, converted to uppercase.
*/
public static String toUpperCase(String s) {
if (s == null || s.isEmpty()) {
if (s == null) {
throw new IllegalArgumentException("Input string connot be null");
}
if (s.isEmpty()) {
return s;
}
char[] values = s.toCharArray();
for (int i = 0; i < values.length; ++i) {
if (Character.isLetter(values[i]) && Character.isLowerCase(values[i])) {
values[i] = Character.toUpperCase(values[i]);
StringBuilder result = new StringBuilder(s);
for (int i = 0; i < result.length(); ++i) {
char currentChar = result.charAt(i);
if (Character.isLetter(currentChar) && Character.isLowerCase(currentChar)) {
result.setCharAt(i, Character.toUpperCase(currentChar));
}
}
return new String(values);
return result.toString();
}
}
Loading