-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Adding DarkSort Algorithm #6141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1826719
Adding Dark Sort
sahilkumarvalecha 647a5a0
Add test case for null input in DarkSortTest
sahilkumarvalecha 17eca6b
Formatting error in darksort solved
sahilkumarvalecha f171582
Build Error Fixed
sahilkumarvalecha 722cdea
Build and Cling Error Fixed
sahilkumarvalecha c59956b
Changes in Dark Sort
sahilkumarvalecha 9f46b4c
Clang Format linter check resolved
sahilkumarvalecha 755196f
Accepting Only Integers In DarKSort
sahilkumarvalecha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
package com.thealgorithms.sorts; | ||
|
||
/** | ||
* Dark Sort algorithm implementation. | ||
* | ||
* Dark Sort uses a temporary array to count occurrences of elements and | ||
* reconstructs the sorted array based on the counts. | ||
* | ||
* @see SortAlgorithm | ||
*/ | ||
class DarkSort implements SortAlgorithm { | ||
|
||
/** | ||
* Sorts the array using the Dark Sort algorithm. | ||
* | ||
* @param unsorted the array to be sorted | ||
* @param <T> Comparable class | ||
* @return sorted array | ||
*/ | ||
@Override | ||
public <T extends Comparable<T>> T[] sort(T[] unsorted) { | ||
if (unsorted == null || unsorted.length <= 1) { | ||
return unsorted; | ||
} | ||
|
||
// Dark Sort works only for integers, so we cast and check | ||
if (!(unsorted instanceof Integer[])) { | ||
throw new IllegalArgumentException("Dark Sort only supports Integer arrays."); | ||
} | ||
|
||
Integer[] arr = (Integer[]) unsorted; | ||
int max = findMax(arr); // Find the maximum value in the array | ||
|
||
// Create a temporary array for counting occurrences | ||
int[] temp = new int[max + 1]; | ||
|
||
// Count occurrences of each element | ||
for (int value : arr) { | ||
temp[value]++; | ||
} | ||
|
||
// Reconstruct the sorted array | ||
int index = 0; | ||
for (int i = 0; i < temp.length; i++) { | ||
while (temp[i] > 0) { | ||
arr[index++] = i; | ||
temp[i]--; | ||
} | ||
} | ||
|
||
return (T[]) arr; | ||
} | ||
|
||
/** | ||
* Helper method to find the maximum value in an array. | ||
* | ||
* @param arr the array | ||
* @return the maximum value | ||
*/ | ||
private int findMax(Integer[] arr) { | ||
int max = arr[0]; | ||
for (int value : arr) { | ||
if (value > max) { | ||
max = value; | ||
} | ||
} | ||
return max; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
package com.thealgorithms.sorts; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertArrayEquals; | ||
import static org.junit.jupiter.api.Assertions.assertNull; | ||
import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
class DarkSortTest { | ||
|
||
@Test | ||
void testSortWithIntegers() { | ||
Integer[] unsorted = {5, 3, 8, 6, 2, 7, 4, 1}; | ||
Integer[] expected = {1, 2, 3, 4, 5, 6, 7, 8}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertArrayEquals(expected, sorted); | ||
} | ||
|
||
@Test | ||
void testEmptyArray() { | ||
Integer[] unsorted = {}; | ||
Integer[] expected = {}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertArrayEquals(expected, sorted); | ||
} | ||
|
||
@Test | ||
void testSingleElementArray() { | ||
Integer[] unsorted = {42}; | ||
Integer[] expected = {42}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertArrayEquals(expected, sorted); | ||
} | ||
|
||
@Test | ||
void testAlreadySortedArray() { | ||
Integer[] unsorted = {1, 2, 3, 4, 5}; | ||
Integer[] expected = {1, 2, 3, 4, 5}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertArrayEquals(expected, sorted); | ||
} | ||
|
||
@Test | ||
void testDuplicateElementsArray() { | ||
Integer[] unsorted = {4, 2, 7, 2, 1, 4}; | ||
Integer[] expected = {1, 2, 2, 4, 4, 7}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertArrayEquals(expected, sorted); | ||
} | ||
|
||
@Test | ||
void testNullArray() { | ||
Integer[] unsorted = null; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
Integer[] sorted = darkSort.sort(unsorted); | ||
|
||
assertNull(sorted, "Sorting a null array should return null"); | ||
} | ||
|
||
@Test | ||
void testNonIntegerArray() { | ||
String[] unsorted = {"zebra", "apple", "mango", "banana"}; | ||
|
||
DarkSort darkSort = new DarkSort(); | ||
|
||
// DarkSort should throw an IllegalArgumentException for non-integer arrays | ||
assertThrows(IllegalArgumentException.class, () -> darkSort.sort(unsorted), "DarkSort only supports Integer arrays."); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.