-
Notifications
You must be signed in to change notification settings - Fork 20.3k
Implement topological sort with DAG validation and cycle detection #6568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Implement topological sort with DAG validation and cycle detection #6568
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6568 +/- ##
============================================
+ Coverage 75.19% 75.22% +0.03%
- Complexity 5614 5625 +11
============================================
Files 690 691 +1
Lines 19407 19445 +38
Branches 3755 3763 +8
============================================
+ Hits 14593 14628 +35
- Misses 4247 4250 +3
Partials 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o TopologicalSort
Looks like this is already in the repository, but in the wrong package it is definitely related to the graph |
@siriak, Could you please help clarify our approach here? From my perspective, the optimal solution would be to: Migrate the old implementation here What are your thoughts on this approach? |
clang-format -i --style=file path/to/your/file.java