Skip to content

Conversation

@NayanSaraff
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (a4cf6e3) to head (f225ff3).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6600   +/-   ##
=========================================
  Coverage     78.26%   78.26%           
  Complexity     6567     6567           
=========================================
  Files           743      743           
  Lines         21886    21886           
  Branches       4284     4284           
=========================================
  Hits          17129    17129           
  Misses         4074     4074           
  Partials        683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is mostly correct, but a few improvements are needed before merging:

  1. The class-level Javadoc and the reference comment should be combined and placed directly above the class declaration.
  2. Consider adding more detailed explanations for the methods (nextGreaterElement and nextSmallerElement), including their time and space complexities.
  3. It would be great to include a proper test class to verify correctness for multiple scenarios.

@NayanSaraff

NayanSaraff and others added 3 commits October 8, 2025 18:07
Added main method and test scenarios for next greater and next smaller element functions.
@github-actions
Copy link

This pull request has been automatically closed because its workflows or checks failed and it has been inactive for more than 14 days. Please fix the workflows and reopen if you'd like to continue. Merging from main/master alone does not count as activity.

@github-actions github-actions bot closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants