Monotonic_Increasing_Stack #6600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment block explaining the Monotonic Increasing Stack algorithm and its applications.
Added a comment with a reference link for monotonic stack.
NayanSaraff
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6600 +/- ##
=========================================
Coverage 78.26% 78.26%
Complexity 6567 6567
=========================================
Files 743 743
Lines 21886 21886
Branches 4284 4284
=========================================
Hits 17129 17129
Misses 4074 4074
Partials 683 683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed the main method and related print statements.
Removed unused import statement for Arrays.
Member
DenizAltunkapan
left a comment
DenizAltunkapan
left a comment
There was a problem hiding this comment.
The implementation is mostly correct, but a few improvements are needed before merging:
- The class-level Javadoc and the reference comment should be combined and placed directly above the class declaration.
- Consider adding more detailed explanations for the methods (
nextGreaterElementandnextSmallerElement), including their time and space complexities. - It would be great to include a proper test class to verify correctness for multiple scenarios.
Added main method and test scenarios for next greater and next smaller element functions.
|
This pull request has been automatically closed because its workflows or checks failed and it has been inactive for more than 14 days. Please fix the workflows and reopen if you'd like to continue. Merging from main/master alone does not count as activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java