Skip to content

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 5, 2025

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.04%. Comparing base (c0ca704) to head (0d777dc).

Files with missing lines Patch % Lines
...rithms/datastructures/bloomfilter/BloomFilter.java 30.43% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6636      +/-   ##
============================================
- Coverage     77.10%   77.04%   -0.07%     
+ Complexity     6110     6103       -7     
============================================
  Files           719      718       -1     
  Lines         20437    20439       +2     
  Branches       3952     3955       +3     
============================================
- Hits          15758    15747      -11     
- Misses         4080     4093      +13     
  Partials        599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Hardvan

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hardvan
I found that there are multiple PrintAMatrixInSpiralOrder classes:

Please remove the duplicate class in the others package and ensure that only one class remains in the matrix package.
Also, move your updated class (with improved documentation) and the corresponding test file into the matrix package so at the end there exists only one class in the matrix folder

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 12, 2025

@DenizAltunkapan Done

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) October 12, 2025 09:06
@DenizAltunkapan
Copy link
Member

DenizAltunkapan commented Oct 12, 2025

Thanks @Hardvan. Please merge from master to merge this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants