-
Notifications
You must be signed in to change notification settings - Fork 20.8k
feat: added rotating calipers #6669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6669 +/- ##
============================================
+ Coverage 75.75% 75.90% +0.14%
- Complexity 5772 5798 +26
============================================
Files 703 704 +1
Lines 19777 19884 +107
Branches 3832 3846 +14
============================================
+ Hits 14982 15092 +110
+ Misses 4215 4214 -1
+ Partials 580 578 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yadhu-vipin Please fix the failing workflows so I can start the review. |
|
This pull request has been automatically closed because its workflows or checks failed and it has been inactive for more than 14 days. Please fix the workflows and reopen if you'd like to continue. Merging from main/master alone does not count as activity. |
Title: Fix Rotating Calipers: Correct Diameter and Width Calculations
“This PR adds the Rotating Calipers algorithm and its tests. The CI may show unrelated test failures (e.g., BloomFilterTest), but my changes are isolated to the geometry package and pass all their own tests.”
Description:
This PR fixes the
RotatingCalipersimplementation for calculating the diameter and minimum width of convex polygons.Changes made:
diametermethod to correctly compute the farthest pair of points using the rotating calipers technique. Previous calculations returned incorrect distances for simple polygons.widthmethod to compute the true minimum width of the convex polygon, based on perpendicular projections along each edge.testDiameterSimpleTriangleandtestWidthSimpleTriangleto match the mathematically correct expected values.minAreaBoundingRectangle, remain consistent with correct convex hull ordering.Impact:
Triangles and other simple polygons now return the correct diameter and width.
Unit tests pass with accurate geometric values.
References:
Rotating Calipers algorithm (Shamos, 1978)
Convex hull computation for ordered points